Conformance testing for cosign #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
==========================================
- Coverage 40.10% 37.06% -3.04%
==========================================
Files 155 203 +48
Lines 10044 12780 +2736
==========================================
+ Hits 4028 4737 +709
- Misses 5530 7453 +1923
- Partials 486 590 +104 ☔ View full report in Codecov by Sentry. |
Also add e2e test and some helpful error messages about what flags go together Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
haydentherapper
approved these changes
Aug 6, 2024
kipz
pushed a commit
to kipz/cosign
that referenced
this pull request
Oct 21, 2024
* Adding conformance helper and Action Also add e2e test and some helpful error messages about what flags go together Signed-off-by: Zach Steindler <steiza@github.com> * Allow conformance driver to call cosign with user-supplied args Signed-off-by: Zach Steindler <steiza@github.com> * fix e2e test Signed-off-by: Zach Steindler <steiza@github.com> * Detail TODO comments; remove unneeded trusted root in e2e tests Signed-off-by: Zach Steindler <steiza@github.com> --------- Signed-off-by: Zach Steindler <steiza@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the last P0 of #3139, including support for conformance testing, an e2e test, and some CLI warnings about incompatible flags.
Release Note
NONE - although maybe we should break #3139 into smaller chunks, and release the P0 parts of it while leaving the container image parts for a later release?
Documentation
N/A - see above